Metrics changes after prometheus upgrade #624
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
Comment on lines
+11
to
+17
| Teku has introduced changes to metric names due to the upgrade of the Prometheus library. | ||
|
|
||
| Gauge names are not allowed to end with `total`, therefore metrics as `beacon_proposers_data_total` and `beacon_eth1_current_period_votes_total` are dropping the `_total` suffix | ||
|
|
||
| The `_created` timestamps are not returned by default. | ||
|
|
||
| Some JVM metrics have changed name to adhere to the OTEL standard (see the table below) |
There was a problem hiding this comment.
Suggested change
| Teku has introduced changes to metric names due to the upgrade of the Prometheus library. | |
| Gauge names are not allowed to end with `total`, therefore metrics as `beacon_proposers_data_total` and `beacon_eth1_current_period_votes_total` are dropping the `_total` suffix | |
| The `_created` timestamps are not returned by default. | |
| Some JVM metrics have changed name to adhere to the OTEL standard (see the table below) | |
| With the upgrade of the Prometheus library, Teku introduces the following changes to metric names: | |
| - Gauge names are not allowed to end with `total`, so metrics such as `beacon_proposers_data_total` and `beacon_eth1_current_period_votes_total` are dropping the `_total` suffix. | |
| - The `_created` timestamps are not returned by default. | |
| - Some JVM metric names are changing to adhere to the OTEL standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to be merged after the next release will leave it as a draft in the meantime